Refactor/#254 미세먼지 리팩터링 #256
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Results 81 files 81 suites 4m 53s ⏱️ Results for commit ca34278. |
DongminL
reviewed
May 15, 2025
src/main/java/org/programmers/signalbuddyfinal/domain/air_quality/service/AirQualityCache.java
Outdated
Show resolved
Hide resolved
| @Component | ||
| @RequiredArgsConstructor | ||
| @Qualifier("regionStrategy") | ||
| public class RegionAirQualityService implements AirQualityStrategy { |
Collaborator
There was a problem hiding this comment.
AirQualityStrategy의 구현체 이름으로는 SeoulAirQualityStrategy와 RegionAirQualityStrategy가 조금 더 알기 쉽고 명확할 것 같습니다!
Collaborator
Author
There was a problem hiding this comment.
넵 그러네요!!! 반영해서 다시 올리겠습니다!
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
✅ 체크리스트
📝 작업 내용
AirQualityStrategy인터페이스를 통해 다형성 적용AirQualityCacheService로 분리하여 역할 명확화📸 스크린샷 (UI 변경 시 필수)
👀 리뷰어 가이드라인